A Vulnerability in Libsodium

(00f.net)

131 points | by raggi 5 hours ago

5 comments

  • CiPHPerCoder 3 hours ago
    This also affected the PHP library, sodium_compat. https://github.com/FriendsOfPHP/security-advisories/pull/756

    I'm planning to spend my evening checking every other Ed25519 implementation I can find to see if this check is missing any where else in the open source ecosystem.

    • CiPHPerCoder 36 minutes ago
      I found several libraries that simply didn't implement the check, but none that implemented in incorrectly in the same way as the vulnerability discussed above.

      If you didn't receive an email from me, either your implementation isn't listed on https://ianix.com/pub/ed25519-deployment.html, I somehow missed it, or you're safe.

    • hu3 2 hours ago
      Thank you for your work on open source.
  • proof_by_vibes 3 hours ago
    I've been iterating on sodium bindings in Lean4 for about four months, and now that I've gotten to Ristretto255 I can see why the author is excited about its potential. Ristretto is a tightly designed API that allows me to build arbitrary polynomials on Curve25519 and I've been having a blast tinkering and experimenting with it! If the author by chance reads this, just want to say thank you for your work!
    • fshacf 55 minutes ago
      You have a public repo of this?
  • runtimepanic 2 hours ago
    Subtle but important bug. This is a good example of how “is valid” checks in crypto are rarely as simple as they sound. Accepting points outside the prime-order subgroup can quietly undermine higher-level assumptions, even if no immediate exploit is obvious. Also a reminder that low-level primitives tend to be reused far more widely than intended, so small validation gaps can have surprisingly large blast radii.
  • theLiminator 2 hours ago
    If you work for a big company, consider trying to get Frank sponsored by your company.
    • guessmyname 50 minutes ago
      I work for a big company (Apple) but I have no idea who Frank is, nor how to sponsor them; and even if I knew them and how to sponsor them, the money would come directly from my pocket instead of Apple’s banking account.
      • CiPHPerCoder 44 minutes ago
        From the article:

          If libsodium is useful to you, please keep in mind that it is maintained by one person, for free, in time I could spend with my family or on other projects. The best way to help the project would be to consider sponsoring it, which helps me dedicate more time to improving it and making it great for everyone, for many more years to come.
        
        The "sponsoring it" links to https://opencollective.com/libsodium/contribute

        Hope that helps.

        • FiloSottile 5 minutes ago
          Frank does great work that is critical to many businesses, and should get funded to do it professionally.

          However, donating money to an open collective is prohibitively hard for most big companies. Maybe the world should be different (or maybe not, since it would be easy for employees to embezzle money if they could direct donations easily), but that's how it works currently.

          AFAICT, there is also no fiscal sponsor, so the donation matching suggested in a sister comment won't apply.

          This is why Geomys (https://geomys.org) works the way it does, and why it has revenue (ignoring the FIPS and tlog sides of the business) which is 30-50x of some GitHub Sponsors "success stories": we bill in a way that's compatible with how companies do business, even if effectively we provide a similar service (which is 95% focused on upstream maintenance, not customer support).

          I am not saying it's for everyone, or that Frank should necessarily adopt this model, or that it's the only way (e.g. the Zig foundation raises real amounts of money, too), but I find it frustrating to see over and over again the same conversation:

          - "Alice does important maintenance work, she should get professionally funded for it!"

          - "How does Alice accept/request funding?"

          - "Monthly credit card transactions anchored at $100/mo that are labeled donations"

          - no business can move professional amounts of money that way

          - "Businesses are so short-sighted, it's a tragedy of the commons!"

      • AndyKelley 36 minutes ago
        Maybe you don't know this but Apple has a donation-matching program. If you make donations to non-profits through some special internal mechanism, the company will send a donation of equal value (up to some limit). If I recall correctly the limit is 30K USD per person.
        • zenmac 31 minutes ago
          Do you have any links or more info about the special internal mechanism? Would need an apple employee to initiate this I assume?
  • gafferongames 2 hours ago
    Such a great library. Thank you Frank Denis